|
|
Discuss
>
WebGUI Dev
|
|
|
User
|
colink
|
|
Date
|
5/23/2008 2:43 pm
|
|
Views
|
674
|
|
Rating
|
0
Rate [ | ]
|
|
|
Previous
·
Next
|
colink
|
Date: 5/23/2008 2:43 pm · Subject: i18n label testing · Rating: 0
(for review) A long time ago, I wrote a very schlocky test called i18n/label.t. It actually parses the WebGUI source code, looking for i18n calls that lookup table entries that don't exist. It's very slow, taking up to 20 minutes even on very fast machines, but it has also found a lot of broken labels.
In january of 2007, our collective coding proved too powerful for my puny, pathetic parser. So I began writing a Perl::Critic policy to do the same job. As of June, it did a more thorough job of parsing than label.t did. However, it runs about 3-5X slower than label.t. Since it only broke in 1 place, I didn't think too much about it, and got used to seeing label.t failures in every nightly smoke run.
The new rewrite of the EMS breaks label.t pretty thoroughly, and exposes a bug in Text::Balanced, which hasn't seen a new release since December of 2006.
I think it's time to replace label.t with the Perl::Critic policy.
However, that 3-5X slow down (that's 60-100 minutes!) makes me pause so I figured I'd better check with my fellow devs.
What do y'all think about replacing the broken test with the slow but functional test?
|
| Back to Top |
Rate [ | ]
|
| |
preaction
|
Date: 5/23/2008 2:49 pm · Subject: Re: i18n label testing · Rating: 0
I say slow and correct, that's what CODE_COP is for.
Should that be better named?
|
| Back to Top |
Rate [ | ]
|
| |
colink
|
Date: 5/23/2008 3:01 pm · Subject: Re: i18n label testing · Rating: 0
Should that be better named?
Something like: DEV_ONLY works for me.
|
| Back to Top |
Rate [ | ]
|
| |
apeiron
|
Date: 5/23/2008 3:10 pm · Subject: Re: i18n label testing · Rating: 0
On May 23, 2008, at 14:49 :11, wrote:
> preaction wrote:
>
> I say slow and correct, that's what CODE_COP is for.
>
> Should that be better named?
>
Nope. We should add some commit hooks that alert the local authority
if you check in code that upsets the code cop.
I agree with slow and correct, by the way. So long as it doesn't
affect the loading of WebGUI as users see it, I don't see a problem
with taking a bit of time to do something important.
Chris Nehren // Plain Black
p 1.703.286.2525 x 811
m 1.267.573.1000
f 1.312.264.5382
|
| Back to Top |
Rate [ | ]
|
| |
colink
|
Date: 5/23/2008 3:27 pm · Subject: Re: i18n label testing · Rating: 0
I agree with slow and correct, by the way. So long as it doesn't
affect the loading of WebGUI as users see it, I don't see a problem
with taking a bit of time to do something important.
The WebGUI tests don't interfere with loading WebGUI, so we should be safe there.
|
| Back to Top |
Rate [ | ]
|
| |
JT
|
Date: 5/23/2008 3:36 pm · Subject: Re: i18n label testing · Rating: 0
Yup. Slow and correct.
JT On May 23, 2008, at 2:43 PM, <ckuskie@sterlink.net> wrote:
colink wrote:
(for review) A long time ago, I wrote a very schlocky test called
i18n/label.t. It actually parses the WebGUI source code, looking for
i18n calls that lookup table entries that don't exist. It's
very slow, taking up to 20 minutes even on very fast machines, but it has
also found a lot of broken labels.
In january of 2007, our collective coding proved too powerful for my puny,
pathetic parser. So I began writing a Perl::Critic policy to do the
same job. As of June, it did a more thorough job of parsing than
label.t did. However, it runs about 3-5X slower than label.t.
Since it only broke in 1 place, I didn't think too much about it, and got
used to seeing label.t failures in every nightly smoke run.
The new rewrite of the EMS breaks label.t pretty thoroughly, and exposes a
bug in Text::Balanced, which hasn't seen a new release since December of
2006.
I think it's time to replace label.t with the Perl::Critic policy.
However, that 3-5X slow down (that's 60-100 minutes!) makes me pause
so I figured I'd better check with my fellow devs.
What do y'all think about replacing the broken test with the slow
but functional test?
http://www.plainblack.com/webgui/dev/discuss/i18n-label-testing
--
Plain Black, makers of WebGUI http://plainblack.com
|
| Back to Top |
Rate [ | ]
|
| |
|
|
Re: OReilly by koen - Sat @ 06:44pm Re: OReilly by JT - Sat @ 12:46pm Re: Glad to be here by Mike_S - Sat @ 09:11am Partner Marketing Goals? by koen - Sat @ 08:15am Re: OReilly by koen - Sat @ 08:07am Re: Glad to be here by koen - Sat @ 08:05am
|