I've been looking through the code, I'm thoroughly confused about what "archived" means.  It seems to be mainly associated with "status" (see , AssetLineage, POD for getLineage) but it's included in several SQL queries for state (see AssetLineage, lines 180 and 195).  The funny thing about that is I don't see anywhere where state is assigned to archived.  So...help!

What is the difference between state and status for Assets?

What are the valid values for state and status?

EDIT: "status" is where "archived" is set. It's set by a workflow activity, "ArchiveOldThreads"

Thanks, Doug!  That helps a bunch.

But I think my question of "Where is 'state' set to 'archived'?" still stands. It's used in SQL queries:

 AssetLineage.pm:195:    my ($count) = $self->session->db->quickArray("select count(*) from asset where state in ('published', 'archived') and lineage like ?", [$self->get("lineage")."%"]);

and in 3 or 4 other places. (Try ack archived . | grep state to get them all)

See what I mean?  If state is never set to archived, why should it be queried for?  Should those comparisons be "state=published or status=archived" instead?  Or is the archived check just dead code that we can remove?

Updated with IRC notes:

01:47 <@rizen> yeah, state never uses archived
01:47 <@rizen> only status
01:48 < perlDreamer> so should the logic be reduced to just state=published (and ignore state) or does it need to be state=published OR status=archived?
01:49 < perlDreamer> i.e. AssetLineage line 195
01:54 <@rizen> actually
01:54 <@rizen> it needs to be changed to state='published' and (status='approved' or status='archived')
01:57 < perlDreamer> asset.state='published' and (assetData.status in ('approved','archived'))

Do we need another clause, even beyond that?

(asset.state='published' and (assetData.status in ('approved','archived')))

OR

(assetData.tagId = $self->session->scratch->get("versionTag"))