I'm looking into a bug I've reported[1] regarding headers not being set correctly for images. I've confirmed the behavior I reported by uploading an image to the demo server. I'd like to get this fixed since it's impacting our development work.

It should be a simple matter of sending the correct MIME type header to the browser. However, I'm still learning the ropes of how a request is processed through wG and could use some help.

So far I've found where the www_view method is called in the WebGUI::Asset::File module which I think is the method that processes the request. I can see where the data is being sent but the header is never being set. Is this something that should occur in the www_view method or does it take place somewhere else. What API should I be looking at to find how to set the header? I'll be glad to supply a patch if I can get this fixed for our servers. 

Thanks,
William

[1] http://www.plainblack.com/bugs/tracker/invalid-mime-type-set-for-images 

… except that they do stream the files directly now, because I had to change that to make it work with the exporter, which I suppose is what broke this.  D'oh.

Thanks for the response. I looked at the www_view method in WebGUI::Assets::File::Image; it calls back to its parent which is WebGUI::Assets::File.

The code I'm seeing in W::A::File is not doing a redirect: 

        # Kludge for now to make this work with the exporter.
        my $path = $self->getStorageLocation->getPath($self->get('filename'));
        my $fh = eval { FileHandle->new($path) };
        defined($fh) or return "";
        binmode $fh or ($fh->close, return "");
        my $block;
        while (read($fh, $block, 16384) > 0) {
                $self->session->output->print($block, 1);
        }
        $fh->close;
        return 'chunked';

Perhaps whoever put the "kludge" in there didn't realize it would break the expected behavior? 

William 

PS: How do you get quoting in the rich text editor? Or are you replying via your email client? 

The theoretically-correct solution is probably to make the exporter notify www_view that it's doing an export, and for file assets to switch their behavior based on that.  I didn't see any convenient way of flagging that at the time, IIRC.